search

vitkarpov / grunt-nunjucks-2-html

Compiles nunjucks templates *right* into HTML
MIT License
35 stars 11 forks source link

leaking-vars-tests #15

Closed ArmorDarks closed 9 years ago

ArmorDarks commented 9 years ago

Added requested in #9 files

I hope I didn't miss anything.

Should I update compare.js, or create new one in tests/leaking-vars?

vitkarpov commented 9 years ago

I think we could use the same compare.js, at least for a while

vitkarpov commented 9 years ago

It would be great to see test in compare.js which fails, so I could merge the pr and try to explore the problem. The solution is when the test starts to pass.

ArmorDarks commented 9 years ago

Ops, fixed doubled line :)

I've added compare.js, but I'm not sure about it's syntax, since I'm not very familiar with expect. Please, check it out.

vitkarpov commented 9 years ago

Seems ok :+1: Let's fix the comparing as I mentioned above and let's merge this.

ArmorDarks commented 9 years ago

Uh, I'd want to say that I'm just still learnin js, but it seems to be more related to my inattentiveness :(

I hope that time I didn't miss anything.