search

vitmalina / w2ui

UI widgets for modern apps. Data table, forms, toolbars, sidebar, tabs, tooltips, popups. All under 120kb (gzipped).
http://w2ui.com
MIT License
2.65k stars 733 forks source link

Ensure original event is included in toolbar button event details #2499

Closed ryanjbudhu closed 7 months ago

ryanjbudhu commented 7 months ago

Let me know if I should open up an issue first, but for such a small change I figured I could just go ahead and create a PR. I noticed this with grid toolbars, but obviously the toolbar is a separate object.

If you debug the onClick() for toolbar buttons (built-in or custom) the event.detail.originalEvent property is undefined. I needed the event property to get the PointerEvent object to see if the ctrlKey property was True (whether the user was pressing the control key on the keyboard, so I can open the link in a new tab). Looking at how w2utils.bindEvents() works I figured out I just needed to add the "event" string to the data-click attribute list. This seems to fix it. I don't know if this affects anything else, and I noticed that if the item.id is after the new event string the grid breaks and fails to initialize (no errors to the console though so I don't know what happened, I switched them and it worked so I didn't dig deeper).

vitmalina commented 7 months ago

Your fix is good. Thank you.