search

vito / bass

a low fidelity scripting language for project infrastructure
https://bass-lang.org
MIT License
378 stars 13 forks source link

pkg/bass/ground.go: add quotes around godoc arguments #252

Closed srenatus closed 2 years ago

srenatus commented 2 years ago

Fixes #251.

ℹī¸ I've not tried to check that this works locally. Or rather, I've tried the actual call in the REPL, but I haven't tried building the docs.

srenatus commented 2 years ago

I'll look into running the correct steps to get this green. Just been lazy so far here...

vito commented 2 years ago

No worries, I've been a bit under the weather lately (nothing serious) so I've gotten lazy myself with PRs. :laughing:

There's no easy re-triggering at the moment with Bass Loop (besides rebase+push) so I can just merge this as-is; it seems obviously fine.

I'll leave it around for a bit in case you're still troubleshooting #196 but let me know and I'll just merge it in.

srenatus commented 2 years ago

Tried force-pushing while the runner was running -- I haven't noticed anything on its local logs, but loop seems to have found it to be successful: https://loop.bass-lang.org/runs/39c06b5f-9fd1-401b-a599-7e18bc60c616. However, it's still Waiting for status here 🤔

srenatus commented 2 years ago

Hmm looking at the other PR in the bass loop logs, there's checks that succeeded; I don't find any of those for my runs... 🔍

srenatus commented 2 years ago

I'll open another one, just for trying the obvious... Sorry for the noise 🙃

srenatus commented 2 years ago

🙈 Now the two PRs with the same commit have their status reported in both places, or something...? It looks like #255 is more promising, but it also changed the status here, which is unexpected.

srenatus commented 2 years ago

The other PR got picked up by the runner. I'll close this one.