vitobotta / hetzner-k3s

The easiest and fastest way to create and manage Kubernetes clusters in Hetzner Cloud using the lightweight distribution k3s by Rancher.
MIT License
1.91k stars 143 forks source link

fix cloud-init schema validation error when {{ growpart_str }} is not empty #432

Open EnDjeee opened 2 months ago

EnDjeee commented 2 months ago

{{ growpart_str }}, when is not empty, breaks cloud-init schema validation.

This is easily fixed by moving {{ growpart_str }} up in the template file.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vitobotta commented 2 months ago

Thanks for the PR! It seems that I moved that section to the wrong place in one recent update. Are you using microOS for your cluster?

EnDjeee commented 2 months ago

Yes, I’m using microOS for the cluster nodes. I had to hardcode an extra environment variable into ‘master_install_script.sh’ and generate a new binary to make the installation work, though. Maybe I’ll open a new issue with the details.

vitobotta commented 2 months ago

That would be nice, thanks!