search

vitobotta / hetzner-k3s

The easiest and fastest way to create and manage Kubernetes clusters in Hetzner Cloud using the lightweight distribution k3s by Rancher.
MIT License
1.91k stars 143 forks source link

Switch to standard cluster-autoscaler image #480

Closed ghaering closed 2 weeks ago

ghaering commented 2 weeks ago

Hetzner started sending emails to all customers using the docker.io/hetznercloud/cluster-autoscaler images. The email reads that these images were only provided temporarily until offical releases by upstream cluster-autoscaler were ready. They ask us to start using the official images and that they will REMOVE their own images on November 19 2024.

I have tested this by rebuilding the CLI tool, creating a cluster and creating a deployment that triggered the autoscaler.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

trinhthinh388 commented 2 weeks ago

I wonder if will re-run the create command work with the existing cluster?

ghaering commented 2 weeks ago

@trinhthinh388 I don't know and have not tried yet. But the autoscaler in your existing clusters will stop working in two weeks if it happens to be rescheduled to a different node.

As a workaround, you go to your existing cluster and "kubectl edit deployment" the cluster autoscaler and replace the image. This works fine.

You might have to "kubectl rollout restart" the deployment.

trinhthinh388 commented 2 weeks ago

@trinhthinh388 I don't know and have not tried yet. But the autoscaler in your existing clusters will stop working in two weeks if it happens to be rescheduled to a different node.

As a workaround, you go to your existing cluster and "kubectl edit deployment" the cluster autoscaler and replace the image. This works fine.

You might have to "kubectl rollout restart" the deployment.

Yeah! that makes sense. Thanks @ghaering

vitobotta commented 2 weeks ago

I will merge this PR and make a release with this change after dinner in a bit.

@trinhthinh388 If you rerun the create command, hetzner-k3s will automatically update the cluster autoscaler with the new image.

@ghaering If you edit the deployment manifest directly the deployment gets automatically restarted, so there is no need to do it manually.

vitobotta commented 2 weeks ago

Merged. I'll do a quick test and then release.

vitobotta commented 2 weeks ago

Released 2.0.9. Thanks @ghaering for the PR!