Use Site PHP Version to Run Composer Install

vitodeploy / vito

The Ultimate Server Management Tool

https://vitodeploy.com

GNU Affero General Public License v3.0

1.06k stars 166 forks source link

Use Site PHP Version to Run Composer Install #218

Closed devsarfo closed 4 months ago

devsarfo commented 4 months ago

As mentioned by @maxcelos When creating a new site with the "Run composer install --no-dev" flag, it runs with the default PHP CLI, ignoring the PHP version selected in the form. It should use the selected PHP version.

This should pass the php_version to the getScript function to be used in the composer-install.sh

saeedvaziry commented 4 months ago

@devsarfo VitoDeploy doesn't set that kinda aliases for PHP binary.

devsarfo commented 4 months ago

@saeedvaziry The change uses the php_version from the Site Model as shown below.

The version would be 8.2 instead of 82 and the command would run as shown below

saeedvaziry commented 4 months ago

@devsarfo oh my bad. thats cool tnx