vitodeploy / vito

The Ultimate Server Management Tool
https://vitodeploy.com
GNU Affero General Public License v3.0
1.06k stars 166 forks source link

Update ssh key validation to accept other common standards #228

Closed austinkregel closed 4 months ago

austinkregel commented 4 months ago

👋🏻 Hello!

Thanks for making Vito! I really like what you've got here, and hope to contribute more 😄 Recently left Forge since my sites usually only get myself or some friends as visitors 😆

As for this PR, I've updated the SSH validation to use phpseclib to validate the SSH keys. In the current version of phpseclib, they're validating for EC, RSA, DSA, and X509.

Coincidentally this happens to take care of this issue that was opened last week 👀 I personally use Ed25519 and look forward to this being supported, even if the eventual version looks different than what I have.

Please let me know if you'd like me to change/discuss anything.