vitor251093 / KHMelonMix

Kingdom Hearts 358/2 Days - Melon Mix (DS Emulator)
GNU General Public License v3.0
223 stars 11 forks source link

Results Screen Top Only bug #152

Closed Scatlink closed 3 months ago

Scatlink commented 3 months ago

Describe the bug In V0.3.0 if you finish or quit a mission with no items picked up or earned, the blank surrounding screen goes pink and focuses on the top screen only. This displayed correctly on V0.2.2.

To Reproduce Steps to reproduce the behavior:

  1. Go to any mission
  2. Click on 'withdraw' to quit the mission to the Results screen
  3. If no items load on the bottom screen, the Top Screen goes into Full Screen 4:3 focus with a pink border instead of the usual grey
  4. This causes trying to leave the Results Screen difficult as you cannot see the bottom screen selection menu

Expected behavior As stated, in V0.2.2 this wasn't a problem; both top and bottom screens on the Results Screens would display side by side with the grey screen border; regardless if any items were collected or not.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context n/a

Ssheph95 commented 3 months ago

I'd like to add that this also seems to occur in pretty much every mission when playing mission mode, regardless of if items were collected or not.

image image Second image shows what the results screen looks like if setting the layout to "auto" rather than "top only"

Ssheph95 commented 3 months ago

A speculative update on this. It seems to generally occur when there are specifically fewer than 3 item rows, making this more prevalent in mission mode and challenges than in regular missions. I've been running missions and challenges for about 20 hours and get this screen pretty much consistently, but running normal missions it hadn't occurred at all.

Formal test here involved playing a mission in mission mode that got me 4 distinct types of items collected, save-stating before leaving the mission, and discarding items until the bug occurred. This mission happened to be mission 79.

image 4 item rows.

image 3 item rows.

image image 2 item rows.

image 1 item row.

image Still 1 item row, none collected though.

There's not really a good way to test the case of 2+ rewards rows with no collected rows, except if starting a new game. I'll explore that further if the opportunity arises though.

Ssheph95 commented 3 months ago

Explored further with a quick new game through the tutorial levels, and I seem to have formed a more specific hypothesis. The bug seems to occur any time there are less than 4 TOTAL entries between the two columns.

image image

This seems to be consistent between different missions, rewards, and types of items. All these screencaptures were taken in "Even" screen mode, but the bug is clearly visible on the right (top) screen when and where it occurs.

vitor251093 commented 3 months ago

@Ssheph95 are you capable of reproducing the bug with the latest Actions build?

Ssheph95 commented 3 months ago

@vitor251093 unfortunately I'm away on work without my computer for the next few days (writing from phone). I'll check when I get back, but probably won't be able to test until Sunday or Monday, so if there's a more readily available player, you might be able to consult them faster.

Ssheph95 commented 3 months ago

https://github.com/vitor251093/KHMelonMix/assets/97009666/b97b0b06-4888-4a31-905e-01b96e75ec3f

https://github.com/vitor251093/KHMelonMix/assets/97009666/15fe855a-c48e-45b1-a1ae-842a0fca5f73

image

I ran a few tests and can confirm that the original issue of "top screen only" is fixed for any amount of items. However, there is still a persistent graphical oddity when only one item is present, as shown by the videos linked. This graphics thing appears only with one item, as two, three, and further don't have any issue whatsoever. The main bug that is subject of this issue has been solved though.

vitor251093 commented 3 months ago

Just made an adjustment that should fix the problem for good. Could you please confirm if it's working @Ssheph95 ?

vitor251093 commented 3 months ago

Confirmed to be fixed by ZLGNF from the Discord server