search

vitor251093 / KHMelonMix

Kingdom Hearts 358/2 Days - Melon Mix (DS Emulator)
GNU General Public License v3.0
169 stars 7 forks source link

Hearts gauge display resize causes visual glitches #158

Closed Ssheph95 closed 1 week ago

Ssheph95 commented 3 weeks ago

Describe the bug The resizing of the hearts gauge causes rare visual issues when other HUD elements are near that area of the screen.

To Reproduce This is most observable when the targeting cursor is on an enemy in the top left corner, or when the hearts gauge itself reaches the thousands digit.

Expected behavior ideal behavior is that the hearts gauge resize shouldn't impact other HUD elements. Or it may be that the hearts gauge needs to be un-resized if its bounding box is interfering with the HUD overall.

Screenshots image image

Desktop (please complete the following information):

Additional context Mentioned this on the discord last week but forgot to actually create the issue for it. This issue may be related to issue #156 in that it has to do with the uppermost HUD elements in the play window,

vitor251093 commented 3 weeks ago

This issue may be related to issue #156 in that it has to do with the uppermost HUD elements in the play window,

Those are actually different. The heart is rendered using the DS 3D renderer, while the enemy name is rendered using the DS 2D renderer, so the approach to change their size and aspect ratio is different.

Still, this is indeed a bug that needs to be dealt with.

vitor251093 commented 1 week ago

Based on my tests, this seems to be now fixed in the latest Actions build. @Ssheph95 could you please confirm?

Ssheph95 commented 1 week ago

I've run about half a dozen missions and have been unable to reproduce the lock-on stretching behavior or the 4th digit heart counter stretching, I think we can consider this one officially solved!