vitor251093 / KHMelonMix

Kingdom Hearts 358/2 Days - Melon Mix (DS Emulator)
GNU General Public License v3.0
215 stars 10 forks source link

cutscene build bugs #186

Closed sandwichwater closed 1 month ago

sandwichwater commented 1 month ago

Double cutscenes fail currently any scene that has back to back cutscenes do not play the second scene , examples being xions death and post riku fight , likely due to pressing skip skipping them both . can be fixed short term by simply merging them together but long term will be a problem playing them in theatre mode when it comes to playing them individually so thats not ideal

Credits bugged the credits cutscene is bugged , it will play the original ds audio sped up with a black screen and never end , this is likely due to how the end screen works . the end screen is considered part of the cutscene , if you skip the credits it skips the end screen which is a problem . does work if played through theatre mode but that in and of itself is bugged

Inconsistent player sometimes scenes wont play correctly , instead it will skip the ds scene without playing the hd scene with one of two scenarios : either the audio of it will continue playing over the game until it either ends or another scene plays , or the scene will fully skip with not even the hd scenes audio playing . not consistent

Patched ROMs patched roms do not work , the game simply does not play the hd scenes . this goes for patches that do not touch the "mv" folder in the rom as well , meaning audio mods and fan translations are broken

minor bugs (arent game breaking) : when an hd scene starts or ends it shows a frame from a seemingly random point in the past

when an hd scene starts the in engine music speeds up , a result of the current method used so theres no real way to get around it yet + should be fixed with music replacement (unless its fixed beforehand)

regarding the previous point ^ on occasion after an hd scene plays sometimes music from before the cutscene is heard . again , its just a result of the current method used and will likely be fixed

ZLGNF commented 1 month ago

As of the latest build, in New Game, the DS Opening will play after the HD Opening finishes or is skipped.

If you stay in the title screen for too long the opening will try to play but as for right now, it doesn't play and instead the emulator speeds up and the screen turns black. Keep in mind, you're still in the title screen as you can hear the music faster then normal and you can try to load your saves and if you do manage to load a save the HD opening will play before the game continues as normal.

And then you have the whole "The same cutscene can't be played again unless another cutscene plays"

vitor251093 commented 1 month ago
vitor251093 commented 1 month ago

Updated complete list:

FIXED

WON'T BE SUPPORTED AT THIS MOMENT

NEW ISSUE

vitor251093 commented 1 month ago

As discovered by Magnus, address 0x0204C21C carries the mission number. Quote:

ok nvm I found a value that matches 1 to 1 with the mission number, I should just be checking for that first when it's always the right solution lmao

the special missions in the challenge mode are identified by adding 100 to their ID, but at some point between 17 and 31 it overflows into the negatives. I'm not sure if any of the missions in between have special version we would have to worry about

the value is set to 0 at the title screen, updated either when starting a mission in story mode, or after selecting a mission in mission mode (before pressing start to begin the lobby)

it doesn't change when exiting the mission so it's not really what mission you're in, but the last mission you've been in, with the titlescreen kinda counting as mission 0

We can use that detect when a cutscene is being played from the Theater, to avoid the bug "Two of the cutscenes in the Theater will trigger two additional cutscenes".

There are also some day specific conditions on the game scene detection system which could benefit from this value.

vitor251093 commented 1 month ago

All issues fixed, or turned into independent issues