vitor251093 / KHMelonMix

KH Melon Mix (DS Emulator)
GNU General Public License v3.0
249 stars 12 forks source link

HD Cutscenes still don't have subtitles #199

Open vitor251093 opened 4 months ago

vitor251093 commented 4 months ago

Describe the bug The HD replacement works, but with no subtitles.

To Reproduce Steps to reproduce the behavior:

  1. Play one of the HD replacements.

Expected behavior There should be one subtitle track for each supported language.

Screenshots N/A

Additional context Subtitles should be stored at: assets/days/subtitles/{lang}/cinematics/*.str

With this, it will be easier share custom made subtitles, thus allowing fan translations to be created.

{lang} should be replaced with a human readable name, so the subtitles can be selected from the custom settings using the provided name. Example: English, Português, Español.

The font of the subtitles should be Comic Sans. It should be colored white with a black border.

EpicGamerNaeNae commented 4 months ago

qmediaplayer has subtitle functionality and I've been able to make it work, however: -it needs the subtitles to be embedded into the video file. This issue could be solved by adding an optional step to the patching process for the official cutscenes that embeds subtitles into them, and any unofficial distributed/user supplied cutscenes would have to have subtitles injected into them. -the font can't be changed. This isn't that big of a deal, but ideally we would be able to use the font from the HD release. image

There's also the issue of creating subtitle files in the first place. Extracting the files from the HD collection gives us access to the files it uses to generate subtitles, but they're not in a typical subtitle format. Thankfully though, they are pretty easy to read, and we could automate a conversion process to turn them into proper subtitle files.

Alternatively, we could create our own subtitle implementation, which could allow the subtitles to be independent of the video file, for the font to be changed, and potentially for us to simply use the HD collection's subtitle file format without converting them beforehand.

Example of one of the subtitle files from the HD collection (despite there being versions of each file for each language, the english version contains all the other languages) (the original extension is .exia2):

hd803.txt

vitor251093 commented 4 months ago

Alternatively, we could create our own subtitle implementation, which could allow the subtitles to be independent of the video file, for the font to be changed, and potentially for us to simply use the HD collection's subtitle file format without converting them beforehand.

I think this is probably the best way to go, considering everything you mentioned.

CpazR commented 3 months ago

I'm curious, are the subtitles in the base game baked into the FMVs? Or is that a separate overlay?

It looks like the latter, but not positive.

vitor251093 commented 3 months ago

It's actually a separate overlay, otherwise the European ROM would have each cutscene stored four times