vitor251093 / KHMelonMix

KH Melon Mix (DS Emulator)
GNU General Public License v3.0
230 stars 11 forks source link

Christopher Lee in video cutscenes #225

Open Mirrorman95 opened 2 months ago

Mirrorman95 commented 2 months ago

Is your feature request related to a problem? Please describe. Christopher Lee is not in the external video cutscenes.

Describe the solution you'd like There should be alternate cutscene videos where all or at least some of the lines Christopher Lee recorded for Days are dubbed back in.

Additional context I really like the fact that the external MEGA folder's version of the cutscene of the last battle between Riku and Roxas used Riku's Theme like it did in the original NDS version of the cutscene. I always thought that KH2FM and KH Days HD got that wrong, so I feel that the external cutscene files in the MEGA folder did right by the original. So whatever else you guys do, please don't change that. However, there were several scenes where Christopher Lee played DiZ in the NDS version as he did in KH2, but he is voiced by Corey Burton in the MEGA videos. Even though the fact that he never voiced some of DiZ's Days cutscenes would cause his lines to introduce an inconsistency in the scenes voice acting, I still feel it should be an option for people looking for the most classic, faithful Days experience possible. However, given how hard it would be to extract clear audio from NDS videos with very lossy compression, I would settle for just the final cutscene, since that entire scene, or at least DiZ's part of that scene, is literally present in its entirety in KH2FM HD. I also think that at least basic linear texture filtering should be a feature of KHMelonMix as it is in the latest versions of DeSmuME, but I suppose that is a limitation of the base engine and not something that can be easily added until it is properly added to MelonDS. Besides those two issues, I think that KHMelonMix translates Days to PCs very well, I appreciate all of the hard work the devs have put in to it thus far. I'm looking forward to continued updates in the future.

vitor251093 commented 2 months ago

However, there were several scenes where Christopher Lee played DiZ in the NDS version as he did in KH2, but he is voiced by Corey Burton in the MEGA videos. Even though the fact that he never voiced some of DiZ's Days cutscenes would cause his lines to introduce an inconsistency in the scenes voice acting, I still feel it should be an option for people looking for the most classic, faithful Days experience possible. However, given how hard it would be to extract clear audio from NDS videos with very lossy compression, I would settle for just the final cutscene, since that entire scene, or at least DiZ's part of that scene, is literally present in its entirety in KH2FM HD.

For now I will give this a low priority, but I can see the appeal.

I also think that at least basic linear texture filtering should be a feature of KHMelonMix as it is in the latest versions of DeSmuME, but I suppose that is a limitation of the base engine and not something that can be easily added until it is properly added to MelonDS.

Actually, we have plans to replace all 2D and 3D textures of the game (3D replacement already works, we just need to finish the textures; and 2D replacement is an ongoing process), so filtering the textures won't be necessary.

sandwichwater commented 2 months ago

I really like the fact that the external MEGA folder's version of the cutscene of the last battle between Riku and Roxas used Riku's Theme like it did in the original NDS version of the cutscene. I always thought that KH2FM and KH Days HD got that wrong, so I feel that the external cutscene files in the MEGA folder did right by the original. So whatever else you guys do, please don't change that.

that was the main concern going into making the cutscenes , preserving the music choices and timing of the originals in full hd , it makes me happy to see someone appreciates it so much , we will not change that :)

However, there were several scenes where Christopher Lee played DiZ in the NDS version as he did in KH2, but he is voiced by Corey Burton in the MEGA videos. Even though the fact that he never voiced some of DiZ's Days cutscenes would cause his lines to introduce an inconsistency in the scenes voice acting, I still feel it should be an option for people looking for the most classic, faithful Days experience possible. However, given how hard it would be to extract clear audio from NDS videos with very lossy compression, I would settle for just the final cutscene, since that entire scene, or at least DiZ's part of that scene, is literally present in its entirety in KH2FM HD.

this has been planned since the start of working on the cutscenes , just something i havent gotten around to , i share your feelings . you may be happy to hear ive been cleaning up his audio from the other ds scenes as best as i can , and i hope the end result is satisfactory

and as vitor said , texture filtering will not be necessary as texture replacement will fix that issue