search

vitorbaptista / shellshare

Live terminal broadcasts
https://shellshare.net
Apache License 2.0
224 stars 23 forks source link

fixed a bug when connection breaks #35

Closed hex0cter closed 8 years ago

hex0cter commented 8 years ago

I have seen this message

'There was an error connecting to the server.'

a lot during my sessions. It usually happens after the session has been idle for a short while. When the connection breaks, retry will not help.

With this change a new connection will be created before retrying. I have tested locally and it seems working perfectly.

hex0cter commented 8 years ago

Hi @vitorbaptista is the repo still maintained?

vitorbaptista commented 8 years ago

@hex0cter Sorry for the delay, I just saw your PR. Thanks for your contribution, I also had many problems with connection failures. How stable has it been for you after your patch?

hex0cter commented 8 years ago

Thanks for merging it @vitorbaptista! After this patch, I haven't seen any of connection failures. It even works after the computer has been put into sleep, which wasn't possible before the patch.

vitorbaptista commented 8 years ago

Cool! This was one of the biggest issues with shellshare in my opinion. I've been testing your patch for a few hours now and it's still going strong. Thanks for your fix :+1:

hex0cter commented 8 years ago

I am glad I helped. Shellshare is a great software, I like it a lot. Thanks for creating it!