Add lazy collection support

vitorccs / laravel-csv

PHP Laravel package to export and import CSV files in a memory-optimized way

MIT License

26 stars 5 forks source link

Add lazy collection support #4

Closed Xint0-elab closed 1 year ago

Xint0-elab commented 1 year ago

Hi Vitor,

First of all, thank you for creating this package. Please consider accepting this pull request to add support for LazyCollection and using a query cursor for generating CSV exports.

This also includes some minor changes:

Set license to MIT in composer.json file.
Remove composer.lock file and ignore it as recommended for library projects.
Allow different versions of orchestra/testbench depending on laravel version support.

Xint0-elab commented 1 year ago

Hi @vitorccs can you take a look at this PR?

vitorccs commented 1 year ago

@Xint0-elab Thanks very much for contributing to the repository.

I am a little busy in the next days, but I can review your PR by the end of March 27th.

I let you know as soon as I review it.

Xint0-elab commented 1 year ago

Hi @vitorccs, let me know if you have questions about this PR.

vitorccs commented 1 year ago

Hi @Xint0-elab I reviewed your code and asked for a couple of minor changes (e.g: use camelCase for variables). I am unable to help you since the commit came from your repository.

Xint0-elab commented 1 year ago

@vitorccs variables in camelCase is done. Do you have any other comments or suggestions?