search

vitordino / reduxtron

:electron: end-to-end electron state management
http://npmjs.com/package/reduxtron
23 stars 2 forks source link

Fixing exports and postBuild #2

Closed goosewobbler closed 6 months ago

goosewobbler commented 7 months ago

There was an issue building the core package with later node versions - see https://github.com/TypeStrong/ts-node/issues/1997. Since the error occurs in postBuild we can work around this ts-node issue by running the setupPackage.js from the dist dir which was created in the build step, instead of the source TS file.

Also the types were not being used so I added an exports key to the package.json.

vitordino commented 6 months ago

hey @goosewobbler, sorry i’ve missed this notification..

i’ve made couple changes on the main branch, and actually adopted couple things you also did..

i started this work of revamping the boilerplates (still wip) because i’ve realized they were only working inside this monorepo..

for now, i’ve “surrendered” myself to rollup for building/packaging the library and basically shipping the code on every possible way (typescript, esm, commonjs, definitions for each etc).

another thing i plan on doing is separating the zustand bit (and any future framework-specific function) onto a different package (yet still inside this monorepo)

i haven’t had much time to dedicate to open source lately, but really glad this project caught your eye (:

goosewobbler commented 6 months ago

Nice, good to see the library going somewhere - I'll close this.