Closed carceneaux closed 3 years ago
I'll add that I recognize modifier keys can be used as well in the initial screen. I find myself preferring the enter
+ enter
ease of use as my preferred method for quickly closing an app. At first, I was wondering why this didn't work until I realized I had to type in a kill signal integer for it to work properly.
Thank you for the submission, but I won’t accept it for several reasons.
You’re changing this to your preference; there’s no data to backup up that other users prefer it this way. Yes, I agree the most common signals are 15 and 9, which is exactly why those have shortcuts directly in the first screen. Said shortcuts are faster for those who use multiple options—there’s no guarantee that Kill with signal
will be the top choice on the second screen because the order is learned by Alfred. I definitely do not want to encourage people to ↵↵ and do a destructive action.
You’re free to make those modifications in your local installation, but these were designed like this on purpose and I’ll need stronger arguments to consider changing them.
More importantly, I can’t in good conscience accept a packaged Workflow to distribute to other users. I don’t know you, and while I have no reason to distrust you I also have no reason to trust you. This doesn’t show any changes, so I have no idea if the modifications you made are legitimate. On that same vein, I have no idea if the changes are good or buggy or follow my code style or are spaghetti. I only accept PRs that change the source files, so I can properly review them. After that, if accepted, I package the Workflow.
Again, thank you anyway.