search

vitorgalvao / alfred-workflows

Collection of Alfred workflows
BSD 3-Clause "New" or "Revised" License
2.44k stars 167 forks source link

feat(DownMedia): add Firefox support #165

Closed dkarter closed 1 year ago

dkarter commented 1 year ago

Motivation

This PR adds support for Firefox and Firefox Developer edition in the DownMedia workflow.

Since there's no longer a need to change any browser settings for these APIs to work, I think it makes sense to add support for these browsers.

I also tested this with multiple windows in those browsers.

Screenshots

CleanShot 2022-12-17 at 21 50 51@2x CleanShot 2022-12-17 at 22 04 43@2x
vitorgalvao commented 1 year ago

Thank you, but I won’t support Firefox until they have proper AppleScript support.

This gets the title of the window instead of the tab, and for the URL it relies on GUI positioning which might change and (in this case) is likely to break on non-English systems.

dkarter commented 1 year ago

Thank you, but I won’t support Firefox until they have proper AppleScript support.

This gets the title of the window instead of the tab, and for the URL it relies on GUI positioning which might change and (in this case) is likely to break on non-English systems.

@vitorgalvao Thank you for considering my pull request. I understand your concerns about AppleScript support in Firefox and the potential for the solution to break on non-English systems. However, I want to reassure you that the solution provided in the pull request does indeed work (the title of the window === title of the tab) and provides value to Firefox users.

While it may not be a perfect solution, I believe it is important to offer some support for Firefox users, even if it is labeled as "experimental" or "limited" support. This is ultimately better than not offering any support at all, as it allows Firefox users like myself and many others, to enjoy this awesome workflow you built.

Ultimately the decision is up to you, but I would really appreciate if you reconsider this PR. Additionally, if any support requests for Firefox come through I'll be happy to be tagged on those and take them on to the best of my abilities.

vitorgalvao commented 1 year ago

Firefox users can still use the workflow, all you have to do is copy the URL before calling dv.

I appreciate your offer to help with support requests, but I have tons of workflows which support browsers, this is far from the only one. For a decade I have refined the ways to support them all and keep them up to date, as browsers are discontinued and introduced. Automation Tasks use this code. This is something I have looked into extensively. My conclusion is it’s not worth it to support Firefox. I want to! Its lack of AppleScript support is the number one reason I don’t use it. But I won’t propagate a solution over multiple workflows if it’s not reliable.

Sadly, this lack of support is another contributor to Firefox’s declining usage. Both online and offline, I haven’t been able to make Firefox developers understand AppleScript support isn’t a power user feature, but something everyone can benefit from because it allows interoperability with other tools. Maybe someone else will have more luck.

Either way, I’ll add support if it becomes an official feature.