Take pictures with camera

KotlinGeekDev commented 2 months ago

NIce PR!

greenart7c3 commented 2 months ago

Should I use different buttons for camera and gallery or show a dialog?

vitorpamplona commented 2 months ago

Hum... I think it depends on the screen. On the new post, a new button is better. On chat, a popup is better. I am not sure what to do on the stories/media feed though..

greenart7c3 commented 2 months ago

I think we can do an animated button like this in the stories feed

vitorpamplona commented 2 months ago

makes sense. We have some of that in the chat (creates public and private buttons)

On Fri, Sep 6, 2024 at 8:02 AM greenart7c3 @.***> wrote:

I think we can do an animated button like this in the stories feed

image.png (view on web) https://github.com/user-attachments/assets/2dadc573-9035-4666-97de-33f0ff3b0205

— Reply to this email directly, view it on GitHub https://github.com/vitorpamplona/amethyst/pull/1043#issuecomment-2333903638, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEB4P2CHQHKKISDSZEDPLDZVGKW5AVCNFSM6AAAAABNQIHJMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTHEYDGNRTHA . You are receiving this because you commented.Message ID: @.***>

This email message is confidential. Any review, dissemination, distribution or copying of this message is strictly prohibited.

vitorpamplona commented 2 months ago

Super nice! Is this ready to merge?

greenart7c3 commented 2 months ago

Yes, you can merge this. Unless you want videos too, for videos I think there's no intent for videos and we need to build a camera ui inside the app

vitorpamplona commented 2 months ago

Unless you want videos too, for videos I think there's no intent for videos and we need to build a camera ui inside the app

Yeah, I hate how Android doesn't provide a simple feed from the phone's main camera app.

vitorpamplona / amethyst

Take pictures with camera #1043