vitorpamplona / amethyst

Nostr client for Android
MIT License
1.17k stars 158 forks source link

Change NewPostView to NewPostScreen to make it route based #1137

Closed geovnn closed 1 month ago

geovnn commented 1 month ago

As discussed in #1119

Changes:

vitorpamplona commented 1 month ago

Very cool! As we move forward, it's likely that we will need to have a newPost screen for every event kind with only the functions associated with them. Do you think we should build multiple routes or just one with parameters? Multiple routes feel more organized.

geovnn commented 1 month ago

That make sense, the only drawback would be if you need to pass complex entities around, but that can be solved passing ids as navigation arguments. I think the benefits of an easier code outweights the drawback.

vitorpamplona commented 1 month ago

Yeah, but we can switch to the new Route system that passes full objects as jsons, like this: https://www.youtube.com/watch?v=AIC_OFQ1r3k

geovnn commented 1 month ago

Cool, didn't know about this!