vitorpamplona / amethyst

Nostr client for Android
MIT License
1.13k stars 155 forks source link

[BUG] reports are published as kind 7 instead of 1984 #874

Open umk0m1qk opened 3 months ago

umk0m1qk commented 3 months ago

Content reports are published as kind 7 "reaction" instead of kind 1984 "reporting." Other clients (consistent with the current spec) are displaying these under a user's "likes" tab on their profile - in some cases fully rendering the offensive content on first load and giving viewers the impression that the user liked/reacted to the content when in fact they reported it!

davotoula commented 3 months ago

Any screenshot please?

umk0m1qk commented 3 months ago

In this case screenshots are inappropriate. Here's the json from an example. I have already contacted the developer of one of the clients that was rendering this content under the reporter's "Likes" tab completely unfiltered on first render. He pushed an update within minutes to eliminate the content but correctly pointed out this is really an Amethyst bug because reports are supposed to be kind 1984, not 7.

{"content":"⚠️","created_at":1716342479,"id":"6ef35dce6fe2202088120b91c3a6415117c2534da5fcc77da177db3336e3e36a","kind":7,"pubkey":"ace13f3ca2ad9acd63e5305b207f09d8c8566f0111901f8887f40fa45f3a9b21","sig":"df9c86ead5a65dc0ea0d318f943eb9f5ad33addbb41b47e980fc85562c5f29a7839ddff2146533a7a7ef33026538480cdb5e958fc5a6183f729e3c54ad0b76e1","tags":[["e","82a27455564c125d729fe031651829205da9a4ae3a32ceae4b180481ebcc0f9b"],["p","1e978baae414eee990dba992871549ad4a099b9d6f7e71c8059b254ea024dddc"],["k","1"]]}

vitorpamplona commented 3 months ago

We post both because many clients don't support reports. The reaction with ⚠️ serves as a report for them.

umk0m1qk commented 3 months ago

Thanks for the reply. I understand the reasoning behind that move, but it seems like a better solution is needed to avoid these critical interoperability issues. Not cool when someone's profile page is covered in CS*M they reported. Might not hold up under forensic review, but the viewing public has already passed judgment.

vitorpamplona commented 3 months ago

Not cool when someone's profile page is covered in CS*M they reported.

What do you mean? Reactions don't show on the profile page.

vitorpamplona commented 3 months ago

There are lots of reactions that are not positive towards the post. So making a reaction feed on a profile without parsing out what each reaction means is a weird choice for that client.

umk0m1qk commented 3 months ago

Nostrudel & Coracle (and maybe others) have a "Likes" tab on their profile views. Both feed this tab with kind 7 events - which makes sense. Nostrudel shows Amethyst kind 7 reports as a tiny⚠️ at least and does not render any of the graphics in the reported note - an acceptable solution. Up until yesterday Coracle displayed kind 7 reports in the "Likes" tab along with the reported note (including unblurred images) without any hint to the viewing public that the profile owner responded negatively or reported that note. To them, it appears the profile owner likes this content.

vitorpamplona commented 3 months ago

Yeah, those types of feeds don't make any sense.