search

vitotai / BrewManiacEsp8266

BrewManiac on ESP8266. Only ESP8266 needed.
155 stars 71 forks source link

PID vs setup Boil temp setting #21

Open franciscopaniskaseker opened 6 years ago

franciscopaniskaseker commented 6 years ago

Issue started in wrong local: https://github.com/vitotai/BMESP8266/issues/1#issuecomment-353764304

Problem: If I set up 95.5 C degrees as a BOIL TEMP in setup menu and after mash-out I set 95.5 C degrees, when it get 93.5 C degrees PID will start on/off heating element (because PID Start = ) until get boil temp and then enable PWM. If I will boil the wort, I do not want PID control anymore.

Suggestion: Change PID decision. If the sensor temp is equal or greater to "boil temp configuration minus pid start variable", enable PWM. Or we can use a OR decision. If what we set is equal to BOIL TEMP, do not use PID. I think the first suggestion is the best.

franciscopaniskaseker commented 6 years ago

Where the PID use is started: https://github.com/vitotai/BrewManiacEsp8266/blob/master/src/BrewManiac.cpp#L1632

from: if ((pidSetpoint - pidInput) < gPidStart)

to: if ((pidSetpoint - pidInput) < gPidStart) && ( pidSetpoint < gBoilStageTemperature ))

franciscopaniskaseker commented 6 years ago

Commit #22