vitotai / BrewPiLess

Use an ESP8266 to replace RPI and Arduino. Running BrewPi without Pi, therefore, BrewPi-Less
357 stars 134 forks source link

BPL 4.1: Restart loop after activating Brewafther #285

Closed jacyker closed 3 years ago

jacyker commented 3 years ago

After upgrading to BPL 4.1, activating the Brewfather option causes the device to fall into a restart loop. Both for OTA and manual updates (including clearing all memory).

PS. It's nice if the update - especially OTA - did not delete the settings, for example remote log, system. Or maybe it is worth adding the import / export option for the settings?

vitotai commented 3 years ago

My ESP32 runs well, but EPS8266 has issues. Different issues happened with framework 2.6.2(can't connect to WiFi), 2.6.1(can't compile), and 2.6.0(Can't finish HTTP session). Still trying to find stable one. Updated: After trying for a few hours, rolling back to framework 2.2.0 seems to work. Let's stick with it before the real issue is found.

jacyker commented 3 years ago

4.1r2 fixed. THX :-)

jacyker commented 3 years ago

And 4.1r3 back to restart loop :-(

By the way - maybe it is worth saving the settings, for example, to a json file and loading them on reboot, so that we do not have to set most of them again after update?!?

vitotai commented 3 years ago

I think I've found the "issue", which is the declaration order of HTTPClient and WiFiClient. It sounds stupid. I spent a lot time reading the source and check difference between 4.0 and 4.1 to find the only difference.

jacyker commented 3 years ago

I confirm. It looks like it's working. I didn't even have to set anything this time (MQTT, BF ID).

THX 👍

Best regards, Patryk

gieljnssns commented 3 years ago

@vitotai I use v4.1 and I'm seeing the same when activating MQTT