search

vitotai / BrewPiLess

Use an ESP8266 to replace RPI and Arduino. Running BrewPi without Pi, therefore, BrewPi-Less
358 stars 134 forks source link

Splash screen? #308

Open Justheretoreportanissue opened 3 years ago

Justheretoreportanissue commented 3 years ago

Hi!

First off: Thanks for a gr8 piece of software!

For people with displays wouldn't a splash screen be good? Instead of just seeing "Initialize WiFi" why not add "BrewPiLess\n vBPL_VERSION"?

As far as I can see changes has to be done in BrewPiLess.cpp in the following code block Before: #ifdef EARLY_DISPLAY DBG_PRINTF("Init LCD...\n"); display.init(); display.printAt_P(1,0,PSTR("Initialize WiFi")); display.updateBacklight(); DBG_PRINTF("LCD Initialized..\n"); #endif

After: (formating looks wrong in post, see attachement) #ifdef EARLY_DISPLAY DBG_PRINTF("Init LCD...\n"); display.init(); display.printAt_P(1,0,PSTR("Initialize WiFi")); display.printAt_P(6,2,PSTR("BrewPiLess")); display.printAt_P(9,3,PSTR("v" BPL_VERSION)); display.updateBacklight(); DBG_PRINTF("LCD Initialized..\n"); #endif

Please excuse my lack of being able to make a Pull request or anything other fancy. This is my first attempt to read and edit code in about 30 years!!

Attached the above code block with correct formatting can be found (fingers crossed it works)

(If this goes down well I have a few other ideas for the OLED displays fourth row that I have implemented, compiled and tested)

Regards, /Jonas...

BrewPiLess.cpp Spash.txt

Scales82 commented 3 years ago

Looks good. Im no code expert but I think utilising githubs functions are the best way to get things reviewed and added in future versions. They just dont get noticed here otherwise I think. Happy to be proven wrong.