search

vitotai / BrewPiLess

Use an ESP8266 to replace RPI and Arduino. Running BrewPi without Pi, therefore, BrewPi-Less
349 stars 131 forks source link

Device setup page calibration only allows integer value, but JsonCommand allows float #422

Closed denisfrench closed 3 months ago

denisfrench commented 3 months ago

Hi; I've noticed on the device setup page (http://brewpiless.local/setup.htm) that when float calibration values are entered, they are converted to an integer. I've only tested with DS18B20s.

However, I am able to enter float a float calibration value using a JSON command (https://github.com/vitotai/BrewPiLess/blob/691a92b89435d3a1124f79776f9185f83488bcc3/doc/JsonCommand.md#sensor-calibration). This does work as a float, and is even then displayed as a float on the device setup page.

Perhaps there is something up with the Javascript that only allows a float value entry? I'm compiling version 4.4 ce1428821f12e2aa687425625735fb9e7f9b4627 using the esp32-oled default build environment and config.

Thanks for your work on this!

vitotai commented 3 months ago

found and fixed. Thank you.

denisfrench commented 3 months ago

Confirmed fixed at my end; thanks! 🙏