search

vitotai / BrewPiLessGx

BrewPiLess with touched TFT.
6 stars 4 forks source link

Bug fixes: DS2413 actuator #5

Closed DMT07 closed 4 months ago

DMT07 commented 4 months ago

Bug fixes:

  1. One-wire data validation fails due to incorrect NOT operator used. Need to be bitwise.
  2. One-wire communication errors are not detected due to invalid logical tests, < and >, on unsigned uint8_t data types.

Due to both bugs being present, the DS2413 works when only one of its two PIOs are used. When both PIOs are used, the output states are erratic and cannot be controlled individually.

vitotai commented 4 months ago

I don't have a DS2413 module and the part of code was derived from the very beginning of BrewPi. Therefore, I assume you are right.