search

vitr-archive / valet4windows

Windows version of Laravel Valet
MIT License
63 stars 5 forks source link

Valet Share does not copy or show the latest ngrok url, but only the first one #7

Open lancepioch opened 8 years ago

lancepioch commented 8 years ago

If you use it more than once, it'll open up multiple ngrok instances (which is fine), but it will keep displaying and copying to the clipboard only the first one.

vitr commented 8 years ago

well, at least, both tunnels are working, just tested. I believe, the problem is in the original valet code public $tunnelsEndpoint = 'http://127.0.0.1:4040/api/tunnels'; the tunnel endpoint is hardcoded and ngrok creates the second on port 4041, and next on 4042, etc. So, we need to keep track of running ngrok instances and picking the right one. I have to test on Mac, but I guess, there might be the same issue.

vitr commented 8 years ago

the issue has been confirmed and reproduced with original valet on Mac. I created an issue here https://github.com/laravel/valet/issues/145