vitruv-tools / Vitruv

View-based Development and Model Consistency Framework
http://vitruv.tools
Eclipse Public License 1.0
14 stars 19 forks source link

Remove MirBase Language and Reactions Postprocessor #449

Closed HeikoKlare closed 3 years ago

HeikoKlare commented 3 years ago

This PR replaces the MirBase language by a set of some common language elements with according scoping and validation capabilities. Since the MirBase language was basically a set of metamodel elements with according scoping, there is no necessity to prescribe a concrete textual syntax with Xtext and have all the additional complexity of inheriting frmo a furtherlanguage.

In addition, the PR removes the Reactions language postprocessor by predefining parts of the language metamodel, which is especially reasonable because the Xtext postprocessor is deprecated. Furthermore, it makes the top-level structure of the language more explicit than having it derived from the textual grammar.

We also make minor improvements, including:

Despite the last point, the Reactions generation is currently quite hard to understand. The improvement has to be seen as a quickfix, especially tolerating for many elements that they may be null. However, there is the need to perform a deeper refactoring of the generator to improve understandability and maintainability of the code.

Resolves #306.