search

vitruv-tools / Vitruv

View-based Development and Model Consistency Framework
http://vitruv.tools
Eclipse Public License 1.0
14 stars 19 forks source link

Adding Functionality to Insert Elements in an EReference at the Last Position #517

Closed NeumannDirk closed 2 years ago

NeumannDirk commented 2 years ago

Addressing #512 this PR adds the mentioned functionality as well as the corresponding tests.

JanWittler commented 2 years ago

In general, it would be beneficial for an open PR to be 1) up-to-date with the master branch and 2) have all tests running You can test your local changes against the applications as documented in the Wiki.

If the PR is not yet ready but you still want to communicate your changes, you can make it a draft PR.

HeikoKlare commented 2 years ago

I propose to close this PR, as it requires much more sophisticated functionality to achieve its goal.

NeumannDirk commented 2 years ago

Thank you for having a look into this, since I had some issues with building and verifying with maven locally. It seems that you found the problem with this PR and therefore the reason why the concept of the "-1"-insertion won't work for now. Therefore, we should close this PR. At least this attempt is documented in this history, and it might be helpful for future attempts to implement a functionality for insertions at the last positions / adding elements without stating a certain index.