search

vitryd / blockly

Automatically exported from code.google.com/p/blockly
0 stars 0 forks source link

playground broken on site #122

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
http://blockly-demo.appspot.com/blockly/tests/playground.html

closure base.js should only be included locally if it is available locally 
otherwise from the closure site:
code.google.com/p/closure-library/source/browse/trunk/closure/goog/base.js

Original issue reported on code.google.com by s...@google.com on 20 Feb 2013 at 2:56

GoogleCodeExporter commented 8 years ago 
Neil - did this ever work before?  I don't see any way to allow code from 
multiple locations using goog.require, which seems to need relative paths :(

Original comment by s...@google.com on 20 Feb 2013 at 4:43

GoogleCodeExporter commented 8 years ago 
Yes there was some clever code in blockly_uncompresed that computed the 
relative path between closure-read-only and core.  This must be determined at 
run-time, not compile-time since the name of the root directory is unknown 
(blockly, static, trunk, etc).  A quick check of blockly_uncompresed shows that 
it is still there, but I can't diagnose with my current Internet connection.

Original comment by danquyn...@gmail.com on 21 Feb 2013 at 4:18

GoogleCodeExporter commented 8 years ago 
The above comment was from Neil.  Yay for Chrome incognito windows that are 
unexpectedly logged into some random person's account...

Original comment by danquyn...@gmail.com on 21 Feb 2013 at 4:21

GoogleCodeExporter commented 8 years ago 
You are right, there is some clever code to detect path to local 
closure-library but use a remote closure-library is not this easy.

In attachment there is a firt test of me.
In blockly_uncompressed.js i implemented a test if there are a local copy of 
closure-library. If not i will incloude the remote library.

But now there are the problems. When i include the blockly files in 
blockly_core_deps.js by absolute url it wont work. Because goog.addDependency 
will prepend its own path. sorry but iam not realy familiar with the goog stuff.

Original comment by henn...@mst.ch on 24 Feb 2013 at 5:12

Attachments:

GoogleCodeExporter commented 8 years ago 
This refactoring has been moved to the experimental branch.  It is no longer 
blocking trunk.

Original comment by neil.fra...@gmail.com on 11 Mar 2013 at 11:06