search

vittominacori / erc1363-payable-token

Reference implementation for the ERC-1363 Payable Token
https://vittominacori.github.io/erc1363-payable-token/
MIT License
132 stars 52 forks source link

remove IERC20 and IERC165 dependencies on IERC1363 #19

Closed TheSnakeWitcher closed 10 months ago

TheSnakeWitcher commented 10 months ago

Hi , I am currently trying to create a ERC1363 compatible token and I am facing an Linearization of inheritance graph impossible error, these and these issues are related to it. . In my case I declare a IERC1363 interface without IERC20 and IERC165 which seems to solve the error. I would like to know what do you think about removing those interfaces. Thanks in advanced.

vittominacori commented 10 months ago

Hello, ERC20 and ERC165 are part of the implementation as defined in the EIP, so it should not be removed.

Can you share the code that gives you that error to check?

In this ERC1363 contract, both ERC20 and ERC165 are extended also if their interfaces are defined in IERC1363 and I have no linearization error.

TheSnakeWitcher commented 10 months ago

Sorry, I miss understood the causes of the error, It is actually related to my use case which isn't general. I opened the issue because I thought that the ERC1363 contract could not be used together with the rest of openzeppelin ERC20 extensions, but it is not the case, my bad, thanks and nice work 👍🏿