search

vittoriozamboni / django-groups-manager

Manage django groups collection based on django-mptt.
MIT License
100 stars 23 forks source link

Add Django 3.0 support #36

Closed OskarPersson closed 4 years ago

OskarPersson commented 4 years ago

Here I have added support for the upcoming Django 3.0. While testing I added a tox configuration which is also reused on travis. I've done my best to keep the support back to Django 1.8 and Python 2.7 but I think it might be worth to consider dropping support for Django 1.8, 1.9, 1.10 and 2.0, as well as Python 2.7 since the Django versions have already lost support and Python 2.7 will do the same January 1st 2020

OskarPersson commented 4 years ago

Travis is testing but I'm not sure why it isn't being reported here? https://travis-ci.org/vittoriozamboni/django-groups-manager/builds/618503585?utm_medium=notification&utm_source=github_status

vittoriozamboni commented 4 years ago

Hi Oskar, thank you for your contribution!

Can you please create a branch for the changes (something like django-3-support) and not commit into master directly? In this way we can test before merging and stash all the changes.

vittoriozamboni commented 4 years ago

My bad, it was already a branch.

OskarPersson commented 4 years ago

And now travis is reporting :D