search

vitusignacio / Steven_Hyakusenrenma

Test results for Hyakusenrenma
0 stars 0 forks source link

create a 'listing-card' component #5

Closed ghost closed 7 years ago

ghost commented 7 years ago

https://github.com/vitusignacio/Steven_Hyakusenrenma/blob/6c3d39b3ef09e9fdcf33a849f64b8fa8893720ae/Step1/index.html#L21

the listing-card should be a reusable component. Please refactor this code so that I can apply classes (like a bootstrap component) to recreate the styles anywhere on the site.

ghost commented 7 years ago

css selectors like on line 65 are fragile and will break when the html changes

https://github.com/vitusignacio/Steven_Hyakusenrenma/blob/master/Step1/sass/main.sass#L65

please use a class instead. For example, listing-card__subtitle (using BEM format) or listing-card-subtitle using OOCSS format)