search

vitwit / resolute

Resolute
https://resolute.vitwit.com/
Other
22 stars 17 forks source link

feat: Implement offchain sequence management for multisig #1462

Closed Hemanthghs closed 2 weeks ago

Hemanthghs commented 2 weeks ago

Closes #1448

Summary by CodeRabbit

Release Notes

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resolute ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:17am
coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces several enhancements across multiple components related to multisig transaction handling. Key modifications include the addition of new optional props (disableBroadcast and isOverview) to several components, adjustments to transaction sorting logic, and the integration of transaction count management. The signTransaction function is updated to accommodate a new parameter for managing transaction sequences. These changes collectively improve the control flow and user interface for handling transactions in the multisig context.

Changes

File Change Summary
frontend/src/app/(routes)/multisig/components/common/BroadCastTxn.tsx Added disableBroadcast and isOverview props to BroadCastTxnProps. Updated btnOnClick logic to navigate based on isOverview.
frontend/src/app/(routes)/multisig/components/common/SignTxn.tsx Introduced isOverview prop in SignTxnProps. Added transaction count retrieval using useAppSelector. Updated signTheTx to include toBeBroadcastedCount.
frontend/src/app/(routes)/multisig/components/common/TxnsCard.tsx Added disableBroadcast and isOverview props. Updated rendering logic for transaction handling. Modified confirmation dialog message.
frontend/src/app/(routes)/multisig/components/multisig-account/DialogConfirmDelete.tsx Centered description text by adding text-center class.
frontend/src/app/(routes)/multisig/components/multisig-account/Transactions.tsx Enhanced transaction sorting and filtering. Introduced sortedTxns array for improved rendering. Added disableBroadcast prop to TxnsCard.
frontend/src/app/(routes)/multisig/components/multisig-dashboard/RecentTransactions.tsx Updated button visibility logic based on transaction count. Added isOverview prop to TxnsCard.
frontend/src/app/(routes)/multisig/utils/multisigSigning.ts Updated signTransaction function to include toBeBroadcastedCount parameter for sequence management.
frontend/src/components/common/CustomButton.tsx Enhanced button styling based on btnDisabled prop.
frontend/src/store/features/multisig/multisigSlice.ts Modified signTransaction thunk to include toBeBroadcastedCount parameter.
frontend/src/types/multisig.d.ts Added signed_at property to Txn interface for tracking signing timestamps.

Assessment against linked issues

Objective Addressed Explanation
Add offchain sequence management for multisig accounts (#1448) ✅

Possibly related PRs

Poem

🐇 In the land of multisig, where transactions flow,
New props and logic help us to grow.
With buttons that guide and counts that align,
Each click brings us closer, all in good time.
So hop along, friends, let’s broadcast with glee,
For the future of signing is bright as can be! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.