vivanmig / QGIS

0 stars 0 forks source link

Plugin approval #1

Open NyakudyaA opened 7 years ago

NyakudyaA commented 7 years ago

@vivanmig Please remove all .pyc files they are automatically created when the plugin starts. How different is this from a user saving the layer as kml and using it in google earth

vivanmig commented 7 years ago

@NyakudyaA Hi there, I have deleted all the .pyc files here: https://github.com/vivanmig/QGIS/tree/master

Export to Google Earth plugin directly converts only the selected features in QGIS into kml when the user clicks on the plugin button without having to go through the GUI to save selection as kml. This is designed for immediate inspection of the geographical location of the selected features. Its function is similar to the Send2GE plugin, except Export to Google Earth exports polygons and lines too.

Upon selecting features and clicking on the Export to GE button as below: image This is the end result: image

NyakudyaA commented 7 years ago

@vivanmig Ok I think It's a good plugin. I would however suggest you do a PR and merge your work with https://github.com/nextgis/send2google_earth/ so that we can have all the export to google earth consolidated into one plugin. I can initiate the discussion for you on their github page

vivanmig commented 7 years ago

@NyakudyaA Thanks very much. It would be great if you could initiate the discussion for us as this is my first plugin and I'm still quite unfamiliar with the plugin merging or publishing process.

NyakudyaA commented 7 years ago

@vivanmig thanks a lot, Just in summary when a plugin is uploaded we check for functionality and if it doesn't exist we approve and if there are other plugins that does almost similar functionality we encourage colloboration. This also allows you to interact with other devs in the QGIS community. I have created an issue https://github.com/nextgis/send2google_earth/issues/9

vivanmig commented 7 years ago

I see. Will we share the ownership to the consolidated plugin?

2017-11-09 22:41 GMT+11:00 mazano notifications@github.com:

@vivanmig https://github.com/vivanmig thanks a lot, Just in summary when a plugin is uploaded we check for functionality and if it doesn't exist we approve and if there are other plugins that doe almost similar functionality we encourage colloboration. This also allows you to interact with other devs in the QGIS community. I have created an issue nextgis/send2google_earth#9 https://github.com/nextgis/send2google_earth/issues/9

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vivanmig/QGIS/issues/1#issuecomment-343129981, or mute the thread https://github.com/notifications/unsubscribe-auth/AaYkaMxHCgQwPWxaV5z1iio5BbH8ezCFks5s0uTugaJpZM4QXkrR .

NyakudyaA commented 7 years ago

Yes, Please do a PR against the https://github.com/nextgis/send2google_earth/ and they will review the plugin. And also please read their comment in the issue

vivanmig commented 6 years ago

@NyakudyaA Hi there, we have just sent a PR to the send2GE plugin owner in this following link, and there's the first cut of the consolidated plugin: https://github.com/nextgis/send2google_earth/pull/10 let us know your thoughts. we look forward to hearing your feedback. image

NyakudyaA commented 6 years ago

Hi @vivanmig what is the status of this plugin? Can you please chase the guys where you did a PR so that your code will be merged. Let me know if you experiencing issues with them

pcav commented 6 years ago

Please give us feedback, so we can publish it. Thanks.

vivanmig commented 6 years ago

Hi there,

I made a pull request to the owner of the Send2Google_Earth plugin on 26 Nov 2017 and uploaded our consolidated plugin zip file but haven't gotten any feedback or reply from the original plugin owner since then.

Below is the link to the pull request I made and the consolidated plugin(zip file) can be found here: https://github.com/nextgis/send2google_earth/pull/10

I have also tagged NyakudyaA https://github.com/NyakudyaA on the following page to inform the PR made on 26 Nov 2017 : https://github.com/vivanmig/QGIS/issues/1

Let me know if you'd like me to forward or upload the plugin elsewhere and whether you're able to view the plugin content.

Cheers.

2018-02-24 1:54 GMT+11:00 Paolo Cavallini notifications@github.com:

Please give us feedback, so we can publish it. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vivanmig/QGIS/issues/1#issuecomment-368031204, or mute the thread https://github.com/notifications/unsubscribe-auth/AaYkaNWBpcd_7hSKnWev38qLbSXzU3Gsks5tXtEqgaJpZM4QXkrR .

pcav commented 6 years ago

Thanks a lot. Do you have the personal address of the original author? It may be worth to ping him.

vivanmig commented 6 years ago

I don't have the owner's personal contact detail, but here is the link to the original owner's Send2google_earth plugin page. They go by the name simgislab on Github: https://github.com/nextgis/send2google_earth

Thanks!

2018-02-24 20:58 GMT+11:00 Paolo Cavallini notifications@github.com:

Thanks a lot. Do you have the personal address of the original author? It may be worth to ping him.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vivanmig/QGIS/issues/1#issuecomment-368216731, or mute the thread https://github.com/notifications/unsubscribe-auth/AaYkaOkrg9mRJy6_kAEG8fIGdpqQu4H5ks5tX901gaJpZM4QXkrR .

simgislab commented 6 years ago

hi there, it seems like we've overlooked your PR, sorry. We'll have a look shortly and will let you know, hopefully next week.

vivanmig commented 6 years ago

no worries, thanks for your time.

2018-02-25 6:10 GMT+11:00 Maxim Dubinin notifications@github.com:

hi there, it seems like we've overlooked your PR, sorry. We'll have a look shortly and will let you know, hopefully next week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vivanmig/QGIS/issues/1#issuecomment-368251846, or mute the thread https://github.com/notifications/unsubscribe-auth/AaYkaCxlAguyHy-KoJ119cyHEb7kV6tZks5tYF6lgaJpZM4QXkrR .

pcav commented 6 years ago

What is the current status of this?

pcav commented 6 years ago

@simgislab any news on this? How do you suggest to proceed with it?