vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
13 stars 1 forks source link

Fix inaccurate method for computing the `fumenOffset` values for the initial measures #28

Closed vivaria closed 1 year ago

vivaria commented 1 year ago

Both methods will produce the same results if no #MEASURE/#BPMCHANGE commands are present in the first two measures. However, if these commands ARE present, then you will get wildly different results.

This change doesn't affect 4/6 tests, but for 2/6 tests there were #MEASURE/#BPMCHANGE commands. For these songs, I had erroneously "fixed" the OFFSET values, when they were correct all along. So, I reverted them back to their original values.

Fixes #25.