search

vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
14 stars 1 forks source link

Fix crash for `#SECTION` commands that occur before the first `#BRANCHSTART` #36

Closed vivaria closed 1 year ago

vivaria commented 1 year ago

This PR adds genpe.tja to the test suite, a song that currently fails due to how tja2fumen handles #SECTION commands.

We fix the problems with branching commands in 8ad2102f0adf29f58f7dafbdb4ef5b2b5ae0c70a. (Making sure that any #SECTION commands that occur before the first #BRANCHSTART are properly handled.)

This PR also contains a few refactoring commits to improve the clarity of how the branching logic works, to make further debugging of branching songs easier.

Fixes #33.