Closed vivaria closed 1 year ago
I converted each song one by one using TJAConvert.exe
to see which errors would be thrown:
To summarize: The vast majority of failures are due to invalid TJA charts. However, the timeout songs and the ones that say "Failed to create Fumens" are likely an error with tjafumen
, so I'll dig deeper into these.
I'll also update the issue description accordingly.
However, the timeout songs and the ones that say "Failed to create Fumens" are likely an error with
tjafumen
, so I'll dig deeper into these.
When I ran tja2fumen
for each of these... surprisingly, charts were created just fine for most of them. The ones that truly failed inside of tja2fumen
are:
Traceback (most recent call last):
File "tja2fumen\__init__.py", line 51, in <module>
File "tja2fumen\__init__.py", line 27, in main
File "tja2fumen\parsers.py", line 21, in parseTJA
File "tja2fumen\parsers.py", line 91, in getCourseData
ValueError: Invalid value '2P' for #START command.
[19136] Failed to execute script '__init__' due to unhandled exception!
Traceback (most recent call last):
File "tja2fumen\__init__.py", line 51, in <module>
File "tja2fumen\__init__.py", line 27, in main
File "tja2fumen\parsers.py", line 23, in parseTJA
File "tja2fumen\parsers.py", line 241, in parseCourseMeasures
ValueError: Branches do not have the same number of measures.
[18712] Failed to execute script '__init__' due to unhandled exception!
Traceback (most recent call last):
File "tja2fumen\__init__.py", line 51, in <module>
File "tja2fumen\__init__.py", line 31, in main
File "tja2fumen\__init__.py", line 36, in convert_and_write
File "tja2fumen\converters.py", line 275, in convertTJAToFumen
IndexError: pop from empty list
[3672] Failed to execute script '__init__' due to unhandled exception!
These also seem to be TJA/chart errors, albeit ones that TakoTako didn't catch. But, I'll double-check to be sure.
Given that these failures are either A) chart issues or B) TakoTako bugs, and I've reported the TakoTako bugs upstream, I'm going to close this issue as completed.
Fluto has integrated
tja2fumen
into TakoTako starting with https://github.com/Fluto/TakoTako/commit/f728d694b38da732d06a687b14ebbe676a6ff435. 🎉To test this current configuration of TakoTako + tja2fumen 0.5.2, I have built TakoTako from source. Then, I cloned ESE, fixed some very straightforward chart issues (typos in command names) then ran conversion on the entirety of ESE:
Running
cat LogOutput.log | grep Error | sort
yields:When I re-ran the converter, I got this instead:
Running
cat LogOutput.log | grep Error | sort
yields a shorter list:And running
cat LogOutput.log | grep Ignoring | sort
yields:I isolated all listed tracks into their own folder, then deleted the
conversion.json
files and tried again. Several of the songs successfully converted without any changes. I then repeated this again, and even more songs were correctly converted:Finally, after 4 passes, I seemed to be left with a set of songs that could not be converted:
Audio path does not exist. Check WAVE field in TJA.
’
vs'
)TJA is invalid, branches do not have same measure count.
TJA Metadata is invalid, or points to invalid paths.
DEMOSTART
)SCOREINIT
/SCOREDIFF
, unsupportedSCOREMODE
)Failed to create Fumens for ...
#START 2P
)System.DivideByZeroException: Attempted to divide by zero.
This issue is for debugging and fixing issues preventing these songs from converting.