search

vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
13 stars 1 forks source link

Debug conversion failures in ESE using latest version of TakoTako (Attempt 2) #42

Closed vivaria closed 8 months ago

vivaria commented 1 year ago

This issue is a follow-up to:

In that issue, I tried converting all 2200+ ESE TJAs, then tried debugging the failures. Most of the failures were due to chart issues, which caused TakoTako itself to throw the error in many cases. So, there was not much to fix on the tja2fumen side of things.

However, later on, I realized that there was actually a bug in TakoTako that was interfering with my test:

Because of this bug, tja2fumen wasn't used in ~75% of conversions. So, I need to re-run the conversion for all 2200+ songs, and make sure that tja2bin is never used at all. Then, I need to debug any new failures that didn't show up in my first round of testing.

vivaria commented 8 months ago

Closing as I've debugged tja2fumen's output for all ESE songs, and I feel confident that I am accurately producing warnings for every charting issue in ESE. Any remaining failures are chart errors that I cannot fix within tja2fumen.