Open vivaria opened 1 year ago
DDDDDD has reported two new songs that fail due to #SECTION
/#BRANCHSTART
. I will need to figure out why:
I've made some changes in tja2fumen 0.7.1 that will hopefully address some additional crashes due to #SECTION commands.
I'm not confident enough to mark this as fixed, but I do think things have improved. :)
Songs with basic usage (#SECTION before #BRANCHSTART) convert OK!
However, I have a feeling I don't cover every case... for example, take the ESE chart for Taiko Time:
Here, #SECTION comes after the #N/#E/#M commands, and there are two different
#BRANCHSTART p
commands. So, I'm very curious what thebranch_info
bytes will be in an official fumen, and whether my converter produces the correct bytes.Other songs to test:
My question is: Do any custom charters do weird things with #SECTION/#BRANCHSTART? Like, for example:
#BRANCHSTART r
with no#SECTION
so that there is a cumulative drumroll count#BRANCHSTART p
with no#SECTION
so that the percentage is an average of all#BRANCHSTART
commandsOr, is this behavior so niche that no one ever bothers?