vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
14 stars 1 forks source link

Expand test suite to cover different combinations of `#SECTION` and `#BRANCHSTART` #53

Open vivaria opened 1 year ago

vivaria commented 1 year ago

Songs with basic usage (#SECTION before #BRANCHSTART) convert OK!

However, I have a feeling I don't cover every case... for example, take the ESE chart for Taiko Time:

#BRANCHSTART p,80,98.5
#N
#SECTION
#GOGOSTART
#BPMCHANGE 170
[...]
#E
#SECTION
#GOGOSTART
#BPMCHANGE 170
[...]
#M
#GOGOSTART
#SECTION
#BPMCHANGE 170
[...]
#BRANCHSTART p,80,90

Here, #SECTION comes after the #N/#E/#M commands, and there are two different #BRANCHSTART p commands. So, I'm very curious what the branch_info bytes will be in an official fumen, and whether my converter produces the correct bytes.

Other songs to test:

My question is: Do any custom charters do weird things with #SECTION/#BRANCHSTART? Like, for example:

Or, is this behavior so niche that no one ever bothers?

vivaria commented 1 year ago

DDDDDD has reported two new songs that fail due to #SECTION/#BRANCHSTART. I will need to figure out why:

vivaria commented 9 months ago

I've made some changes in tja2fumen 0.7.1 that will hopefully address some additional crashes due to #SECTION commands.

I'm not confident enough to mark this as fixed, but I do think things have improved. :)