vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
14 stars 1 forks source link

Convert song classes into either Pydantic `BaseModels` or `dataclasses` #56

Closed vivaria closed 1 year ago

vivaria commented 1 year ago

I've implemented Pydantic support in viv/test-out-pydantic, and it's uncovered a few bugs (yay!), but it incurs a fairly big performance hit for type validation. I don't really want to add such a slow down to production (it's pretty antithetical to #55), so I expect that I'll eventually settle on dataclasses instead? :thinking:

There's a way to implement type conversion for dataclasses here: https://stackoverflow.com/a/54863733