vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
12 stars 1 forks source link

Add feature to fix desync from BPMCHANGE in songs previously converted by `tja2bin` #65

Open vivaria opened 7 months ago

vivaria commented 7 months ago

In #64, I added the ability to run tja2fumen on .bin charts, fixing the don/ka types based on timing, for previously-converted bins that don't have the correct don/ka values.

In theory, I could take this further, for example by checking for BPM changes between measures and re-computing the offset values. This should fix desync caused by the old tja2bin, see: https://github.com/Fluto/TakoTako/issues/16

I don't know whether this is wanted, though, so I will leave this for now unless someone specifically asks for it.