SENOTES defects and suggestions for additional features

[Lanthanum-057]

I am Japanese, so I go through a translator. Please understand that there may be strange English.

(For some reason I could not attach the zip file, so I am attaching it as a txt.)

I have a request for corrections regarding the notes in the file you attached. When I convert the attached file, the first 16 beats are "ドドドド..." but the following 24 beats become "ドコドコ" instead. These 24 beats should actually be "ドドドド..." Even in sections where the BPM changes and the SCROLL becomes 0.56 or 0.67, it still becomes "ドコドコ..." It should also be "ドドドド..." in these sections.

Additionally, I would like to request the addition of a command to change the notes to any desired characters. Here's an example:

d = ド o = コ dn = ドン ka = カッ k = カ

dodn = ドコドン dddn = ドドドン kkka = カカカッ

By adding this functionality, it would allow for the creation of a flexible custom fumen. I would greatly appreciate it if you could consider implementing these changes.

senotes_test.txt

[vivaria]

Thank you so much for requesting this feature! ❤️

((No worries about Japanese/English translator -- I do the same thing when reading Japanese Taiko sites 😆))

---

I have a request for corrections regarding the notes in the file you attached. When I convert the attached file, the first 16 beats are "ドドドド..." but the following 24 beats become "ドコドコ" instead. These 24 beats should actually be "ドドドド..."

Thank you for senotes_test.txt -- I will try to test this file, and try to fix the bug. :)

---

Additionally, I would like to request the addition of a command to change the notes to any desired characters. Here's an example:

d = ド o = コ dn = ドン ka = カッ k = カ

This would be very good! (TJAs only having 1 and 2 = d/k has made things hard for me 😓.)

I think I could add this feature to the code very easily. Here are the relevant lines of code:

https://github.com/vivaria/tja2fumen/blob/5474ad0baa698669912600b1d32abb1bc0466353/src/tja2fumen/constants.py#L8-L14

https://github.com/vivaria/tja2fumen/blob/5474ad0baa698669912600b1d32abb1bc0466353/src/tja2fumen/constants.py#L31-L37

It might be easier to only have 1 letter/character per note (dn -> n, ka -> t)? So all together:

d = ド o = コ n = ドン t = カッ k = カ

 TJA_NOTE_TYPES = { 
     '0': 'Blank',
     '1': 'Don',
+    'n': 'Don',   # ドン (do~n -> 'n')
+    'd': 'Don2',  # ド (do -> 'd') 
+    'o': 'Don3',  # コ (ko -> 'o')
     '2': 'Ka',
+    't': 'Ka',    # カッ (ka~tsu -> 't')
+    'k': 'Ka2',   # カ (ka -> 'k') 
     '3': 'DON', 
     '4': 'KA',

Would this be okay? Or is it too confusing?

[Lanthanum-057]

I think it's a really great idea! It would be much appreciated if you could implement this.

[sakurada0291]

There is a new command that is required to convert it into a .bin file, and it's called #SENOTECHANGE.

#SENOTECHANGE refers to a command that changes SENOTES (texts under manually! For example, there is a latest song that has SENOTECHANGE which is KOKODOKO? Maybe DOKKA Island! after Warera Muteki no Dokon-dan (われら無敵のドコン団).

#SENOTECHANGE 2 = ド #SENOTECHANGE 3 = コ

https://youtu.be/R3UlGnRM5kg?si=05wkoRL93TW6CUBa&t=31

However, there is no 1 and 0 in #SENOTECHANGE command.

Reference: https://iepiweidieng.github.io/TJAPlayer3/TJAPlayer3-AioiLight-docs/doc/tja

[sakurada0291]

Thank you so much for requesting this feature! ❤️

((No worries about Japanese/English translator -- I do the same thing when reading Japanese Taiko sites 😆))

I have a request for corrections regarding the notes in the file you attached. When I convert the attached file, the first 16 beats are "ドドドド..." but the following 24 beats become "ドコドコ" instead. These 24 beats should actually be "ドドドド..."

Thank you for senotes_test.txt -- I will try to test this file, and try to fix the bug. :)

Additionally, I would like to request the addition of a command to change the notes to any desired characters. Here's an example: d = ド o = コ dn = ドン ka = カッ k = カ

This would be very good! (TJAs only having 1 and 2 = d/k has made things hard for me 😓.)

I think I could add this feature to the code very easily. Here are the relevant lines of code:

https://github.com/vivaria/tja2fumen/blob/5474ad0baa698669912600b1d32abb1bc0466353/src/tja2fumen/constants.py#L8-L14

https://github.com/vivaria/tja2fumen/blob/5474ad0baa698669912600b1d32abb1bc0466353/src/tja2fumen/constants.py#L31-L37

It might be easier to only have 1 letter/character per note (dn -> n, ka -> t)? So all together:

d = ド o = コ n = ドン t = カッ k = カ

 TJA_NOTE_TYPES = { 
     '0': 'Blank',
     '1': 'Don',
+    'n': 'Don',   # ドン (do~n -> 'n')
+    'd': 'Don2',  # ド (do -> 'd') 
+    'o': 'Don3',  # コ (ko -> 'o')
     '2': 'Ka',
+    't': 'Ka',    # カッ (ka~tsu -> 't')
+    'k': 'Ka2',   # カ (ka -> 'k') 
     '3': 'DON', 
     '4': 'KA',

Would this be okay? Or is it too confusing?

I would like to oppose the idea since there is a command that you have not yet acknowledged, but my suggestion will go for plan B if this kind of text doesn't work. Maybe you could remove these suggested highlights or leave at it as some people don't know about how charting works when it comes to handling hashtag commands.