vivaria / tja2fumen

Mod tool to convert TJA chart files (.tja) into .bin files compatible with official games
https://pypi.org/project/tja2fumen/
MIT License
13 stars 1 forks source link

Misalignment of notes #71

Closed Lanthanum-057 closed 7 months ago

Lanthanum-057 commented 7 months ago

I don't know the exact cause, but the notes are shifting more and more as time goes on. The attached images are the part at the beginning and end of the performance. The upper part of the image is the fumen converted using tja2fumen and the lower part is the original fumen. Start00 End00

vivaria commented 7 months ago

Thank you so much for reporting this issue! Could you share the TJA file so that I could test?

Lanthanum-057 commented 7 months ago

I forgot to attach the TJA file. Sorry. ssnrns_x.txt

vivaria commented 7 months ago

Ahhh, this is RNG Cinderella! This is perfect, it allows me to write a new test using the official fumen. 😊

I will get this done by tonight. (Sorry for the delay! I have been sick... 😷)

vivaria commented 7 months ago

Hrmm. I am a bit confused. When I run tja2fumen locally, then compare the converted TJA file to my copy of the official fumen, everything matches 100%.

Converted TJA:

image

image

Fumen:

image

image

(Note that the millisecond offset values ("offset_start") for the measures 97, 98, 99 match, so the timing is the same...)

Here is the official fumen (NS2) that I am testing against: ssnrns.zip

Could you please share the official fumen are you comparing with? (I want to check to see if it is the same official fumen I have.)

Lanthanum-057 commented 7 months ago

My apologies. I just converted it again and played it back at the same time and it matched perfectly. I converted the same TJA, but maybe there was some kind of bug only then. Sorry for the trouble.

vivaria commented 7 months ago

No need to say sorry!! Your issues are still very good and helpful -- it is always good for me to double check and make sure everything is working 100%. ♥️ ♥️

Thank you for reporting anyway, and I hope that you will continue to open issues whenever something goes wrong. ❤️