vivarium-collective / vivarium-core

Core Interface and Engine for Vivarium
https://vivarium-core.readthedocs.io/
Apache License 2.0
25 stars 2 forks source link

don't use timestep for quiet paths #191

Closed prismofeverything closed 2 years ago

prismofeverything commented 2 years ago

A previous PR pulled the calculation of which timestep to advance to the top level of the update loop, which meant the timesteps for quiet paths were being expressed even though they weren't being calculated or making updates. This was causing problems with combining processes with small time steps with processes with large time steps.

The fix is to avoid updating the timestep if the process is not updating due to not meeting it's update condition in the current state.


By creating this pull request, I agree to the Contributor License Agreement, which is available in CLA.md at the top level of this repository.