Removing dtypes from serialize.py that are not available on several platforms

vivarium-collective / vivarium-core

Core Interface and Engine for Vivarium

https://vivarium-core.readthedocs.io/

Apache License 2.0

25 stars 2 forks source link

Removing dtypes from serialize.py that are not available on several platforms #199

Closed cyrus-bio closed 2 years ago

cyrus-bio commented 2 years ago

This PR closes #196, removing np.float128 and np.complex256 from serialize.py as they do not exist for numpy on some platforms (including Windows, ARM-based MacOS, which breaks scripts when trying to import them.

By creating this pull request, I agree to the Contributor License Agreement, which is available in CLA.md at the top level of this repository.

eagmon commented 2 years ago

Interesting. test_hyperdivision fails with assert view_values_times < 0.1 * total_runtime.... the compute time has increased by some amount apparently. I wonder by how much?

eagmon commented 2 years ago

oh, it passed upon retesting. Ok, looks good to merge!