Fix memory leak and parallel process division

vivarium-collective / vivarium-core

Core Interface and Engine for Vivarium

https://vivarium-core.readthedocs.io/

Apache License 2.0

25 stars 2 forks source link

Closed thalassemia closed 2 years ago

thalassemia commented 2 years ago

Parallel processes were not properly saving certain class attributes, including _parallel, causing them to be lost upon pickling during division.

Additionally, we were not properly ending parallel processes when deleting stores, causing a memory leak.

Both of these issues are fixed in this PR.

By creating this pull request, I agree to the Contributor License Agreement, which is available in CLA.md at the top level of this repository.

eagmon commented 2 years ago

Fantastic @thalassemia! Just a few lines of code, but so significant