search

vivarium-collective / vivarium-core

Core Interface and Engine for Vivarium
https://vivarium-core.readthedocs.io/
Apache License 2.0
26 stars 3 forks source link

Make TimelineProcess a Step #212

Closed thalassemia closed 2 years ago

thalassemia commented 2 years ago

This corrects TimelineProcess to apply updates at the time(s) indicated in the timeline. Before, specifying an update at t=0, for example, only results in an updated simulation state after a timestep has elapsed.

By creating this pull request, I agree to the Contributor License Agreement, which is available in CLA.md at the top level of this repository.

thalassemia commented 2 years ago

That's true. Leaving this as is also makes perfect sense if I just think of the timeline as a set of times when actions will occur. In that case, the state should only reflect the results of these actions at the beginning of the following time steps.

We'll just have to keep this delay in mind when using TimelineProcesses.