search

vivarium-collective / vivarium-core

Core Interface and Engine for Vivarium
https://vivarium-core.readthedocs.io/
Apache License 2.0
26 stars 3 forks source link

Make Process.default_state recursive #227

Closed thalassemia closed 1 year ago

thalassemia commented 1 year ago

Though it is rarely used, the Process.default_state method previously broke when a process' ports schema had ports that were either not nested at all or nested more than one level deep. This PR fixes that by making default_state recursive and adds a test to ensure it works.

By creating this pull request, I agree to the Contributor License Agreement, which is available in CLA.md at the top level of this repository.

thalassemia commented 1 year ago

Ready to merge. I'm pretty sure the required statuses thing is something that was configured on GitHub itself under Settings > Branches > Edit master > Require status checks to pass before merging. I can see it for the vivarium-ecoli repo where I am an admin but not for this one.