search

vivax3794 / ComfyUI-Sub-Nodes

Finally sub nodes in comfy!
120 stars 4 forks source link

Suggestions for functionality: #15

Closed 807502278 closed 1 month ago

807502278 commented 1 month ago

Suggestion 1: Add an input to the VIV_Subgraph_Inputs node to specify a default value (this input can be optionally connected when using VIV_Subgraph), similar to UnrealEngine. Suggestion 2: Add a string value to the VIV_Subgraph_Inputs node for specifying the input name. Suggestion 3: Introduce a node of the VIV_Subgraph_Inputs_value type, and when using VIV_Subgraph, make the inputs of this node numeric values instead of connection points(unimportance).

other：NaN bug？ image

MatissesProjects commented 1 month ago

you can do the defaults image one problem with this is that you might end up with items that need to be defined as groups that dont, like in the case shown here you would need the whole model set, but this allows you to do that. image Also I believe the latest version also contains the ability to add strings directly into the graph top.

+1 on that nan bug being a bit strange, but that is likely on the list of things to be cleaned up for ease of life

807502278 commented 1 month ago

Thank you, this vive_default is very useful!