search

vivaxy / alfred-open-in-vscode

Alfred workflow to open in VSCode
GNU General Public License v3.0
36 stars 4 forks source link

newest macos breaks search #18

Open duncan412 opened 11 months ago

duncan412 commented 11 months ago

Hi there!

The latest macos update breaks the search. As soon as you type code, it throws an error. I can not type code DEBUG because of it.

Macos version: 14.1.2 (23B92) NVM default: v12.22.12 Alfred: 5.1.4 Workflow: 1.3.1

I have attached the logs, because it's too long for GH. alfred logs.txt

jackw commented 11 months ago

I've opened a PR that fixes this. To the best of my knowledge I believe it's caused by latest node 21.4.x.

ebenezar-mccoy commented 10 months ago

Same error on v21.5.0. Building from PR https://github.com/vivaxy/alfred-open-in-vscode/pull/19 also doesn't work for me.

jackw commented 10 months ago

@ebenezar-mccoy do you see the same errors in the logs.txt file in this issue description when building from PR #19 ?

lsliwaradioluz commented 9 months ago

I've created a blank workflow (as per alfy's documentation) and copied over the entire index.js file from this repo and it works. Might be a decent workaround for those who need it desperately.

vivaxy commented 4 months ago

I've confirmed that PR #19 does not fix this.

node_modules/esm/esm.js looks suspicious. It looks like this module https://github.com/standard-things/esm. Do you have esm installed or configured?

jackw commented 4 months ago

I've confirmed that PR #19 does not fix this.

Interesting, I tested it out locally and it appeared to solve the issue for me at least.

node_modules/esm/esm.js looks suspicious. It looks like this module https://github.com/standard-things/esm. Do you have esm installed or configured?

The esm package is a dependency of the old version of alfy (0.11.0) this project was using. This is what led me to bump it to latest in #19 .

If you need any assistance with this or someone to test a fix I'm available @vivaxy . Also, thanks so creating this workflow I use it every day. 🥇